Skip to content

channels/fast-4.2: Promote 4.2.19 (and 4.2.19+amd64 to fast-4.3) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 24, 2020
Merged

channels/fast-4.2: Promote 4.2.19 (and 4.2.19+amd64 to fast-4.3) #64

openshift-merge-robot merged 1 commit into from
Feb 24, 2020
+2 −0

Conversation

@thiagoalessio
Copy link
Member

@thiagoalessio thiagoalessio commented Feb 21, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2020
@wking wking mentioned this pull request Feb 21, 2020
Merged
@eparis
Copy link
Member

eparis commented Feb 21, 2020

/approve
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2020
@vrutkovs
Copy link

vrutkovs commented Feb 24, 2020

/lgtm

@wking seems https://openshift-release.svc.ci.openshift.org/releasestream/4-stable/release/4.2.19 has enough tests promote it to fast

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, thiagoalessio, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis
Copy link
Member

eparis commented Feb 24, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 04c5b05 into openshift:master Feb 24, 2020
@wking
Copy link
Member

wking commented Feb 24, 2020

seems https://openshift-release.svc.ci.openshift.org/releasestream/4-stable/release/4.2.19 has enough tests promote it to fast

CI tests are supposed to gate promotion into the candidate channel. To gate promotion into fast/stable, we want to look at Telemetry/Insights to see if anyone running candidate updates in the wild has hit issues or not.

wking referenced this pull request in wking/cincinnati-graph-data Mar 31, 2020
@wking
channels/stable-4.3: Add 4.2.16 through 4.2.19 (amd64)
0364b21 
It's been at least 24 days since the fast promotions landed, so finish
the "phased rollout" and put them in stable.

* 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d
  (Merge pull request #73 from wking/4.2.16-to-fast-4.3, 2020-02-21).
* There was no 4.2.17 (no releases in the week after 4.2.16).
* 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4
  (Merge pull request #60 from wking/fast-4.2.18, 2020-02-20).
* 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05
  (Merge pull request #64 from thiagoalessio/fast-4.2, 2020-02-24).

The previous comments about "only valid into" were from 505f7a6
(Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear
on the motivation.
@wking wking mentioned this pull request Mar 31, 2020
Merged
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Apr 16, 2020
@wking @sdodson
channels/stable-4.3: Add 4.2.16 through 4.2.19 (amd64)
e1ddbe5 
It's been at least 24 days since the fast promotions landed, so finish
the "phased rollout" and put them in stable.

* 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d
  (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21).
* There was no 4.2.17 (no releases in the week after 4.2.16).
* 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4
  (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20).
* 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05
  (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24).

The previous comments about "only valid into" were from 505f7a6
(Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear
on the motivation.
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 14, 2020
@wking @sdodson
channels/stable-4.3: Add 4.2.16 through 4.2.19 (amd64)
579dfcb 
It's been at least 24 days since the fast promotions landed, so finish
the "phased rollout" and put them in stable.

* 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d
  (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21).
* There was no 4.2.17 (no releases in the week after 4.2.16).
* 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4
  (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20).
* 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05
  (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24).

The previous comments about "only valid into" were from 505f7a6
(Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear
on the motivation.
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Jul 29, 2020
@wking @sdodson
channels/stable-4.3: Add 4.2.16 through 4.2.19 (amd64)
453fd4d 
It's been at least 24 days since the fast promotions landed, so finish
the "phased rollout" and put them in stable.

* 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d
  (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21).
* There was no 4.2.17 (no releases in the week after 4.2.16).
* 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4
  (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20).
* 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05
  (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24).

The previous comments about "only valid into" were from 505f7a6
(Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear
on the motivation.
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Aug 24, 2020
@wking @sdodson
channels/stable-4.3: Add 4.2.16 through 4.2.19 (amd64)
826ba00 
It's been at least 24 days since the fast promotions landed, so finish
the "phased rollout" and put them in stable.

* 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d
  (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21).
* There was no 4.2.17 (no releases in the week after 4.2.16).
* 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4
  (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20).
* 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05
  (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24).

The previous comments about "only valid into" were from 505f7a6
(Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear
on the motivation.
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
@wking @sdodson
channels/stable-4.3: Add 4.2.16 through 4.2.19 (amd64)
3fbf4c3 
It's been at least 24 days since the fast promotions landed, so finish
the "phased rollout" and put them in stable.

* 4.2.16+amd64 was promoted to the feeder fast-4.3 by 7660e1d
  (Merge pull request openshift#73 from wking/4.2.16-to-fast-4.3, 2020-02-21).
* There was no 4.2.17 (no releases in the week after 4.2.16).
* 4.2.18+amd64 was promoted to the feeder fast-4.3 by fa66fd4
  (Merge pull request openshift#60 from wking/fast-4.2.18, 2020-02-20).
* 4.2.19+amd64 was promoted to the feeder fast-4.3 by 04c5b05
  (Merge pull request openshift#64 from thiagoalessio/fast-4.2, 2020-02-24).

The previous comments about "only valid into" were from 505f7a6
(Add 4.2 edges into stable-4.3, 2020-03-12, openshift#109), and I'm not clear
on the motivation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@steveej steveej Awaiting requested review from steveej

Assignees

@vrutkovs vrutkovs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thiagoalessio @eparis @vrutkovs @openshift-ci-robot @wking @openshift-merge-robot